-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
typescript project references #3782
Conversation
0364029
to
584b9e2
Compare
9701e04
to
c2b6678
Compare
@zxbodya Will you have a chance to update and resolve the conflicts in this PR? |
@zxbodya Let's get this merged into |
97cae32
to
5a6e862
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we reviewed this a while ago and decided it was ready. Thanks @zxbodya !!
@zxbodya Ok, the new fluent-rc theme is merged, please rebase, update and ready your PR for merge ASAP. I hope to cut a new release by monday |
0ec9d99
to
c846f0e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zxbodya A couple of small tweaks and then I'll merge and build a new release
CHANGELOG.md
Outdated
## Dev / playground | ||
|
||
- update configuration to use typescript project references, start type checking the tests | ||
|
||
## @rjsf/snapshot-tests | ||
|
||
Move theme snapshot tests into separate package | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you reorder these to be after @rjsf/fluentui-rc
with @rjsf/snapshot-tests
first?
packages/snapshot-tests/README.md
Outdated
<h3 align="center">@rjsf/snapshot-tests</h3> | ||
|
||
<p align="center"> | ||
Core logic and classic Bootstrap 3 theme for <a href="https://github.com/rjsf-team/react-jsonschema-form/"><code>react-jsonschema-form</code></a>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs updating to be relevant to the repo rather than a copy of core
Adding configuration for typescript project references
As part of it also splitted snapTests from core to separate package - this is to avoid imports for code not included in package exports, and also will allow themes developed outside oof this monorepo to depend on it.
Reasons for making this change
depends on #3781