fix: Fixed 3778 By Resolving all refs in oneOf/AnyOf options #3786
Conversation
| * @param rootSchema - The root schema that will be forwarded to all the APIs | ||
| * @returns - given schema will all references resolved | ||
| */ | ||
| export function resolveAllReferences<S extends StrictRJSFSchema = RJSFSchema>(schema: S, rootSchema: S): S { |
There was a problem hiding this comment.
@heath-freenome I was debating making this util specifically for oneOf/anyOf options. This is already assuming that the schema went through resolveSchema and has been evaluated with formData. Its just getting the defined $ref and updating the schema.
This might not solve the core issue of oneOf/anyOf options not fully being resolved in resolveSchema but it does solve the existing issue with minimum impact on the whole resolve workflow.
| @@ -258,6 +258,37 @@ export default function sanitizeDataForNewSchemaTest(testValidator: TestValidato | |||
| }) | |||
| ).toEqual({}); | |||
| }); | |||
| it('returns empty formData after resolving schema refs', () => { | |||
There was a problem hiding this comment.
I'm curious about this test. What prompted you to write it?
There was a problem hiding this comment.
For some reason the two changes to resolveAnyOrOneOfSchemas and getClosestMatchingOption caused lose of coverage in sanitizeDataForNewSchema. Maybe because the refs were being resolved and it not longer needed to in sanitizeDataForNewSchema?
Reasons for making this change
fixes #3778 by going through anyOne/oneOf option schema and resolving any $refs.
Checklist
npm run test:updateto update snapshots, if needed.