Fix typo

[DrRac27]

This typo made it silently fail for me so maybe it would make sense to additionally check if a valid Literal was passed?

Thanks for this awesome library btw, I really appreciate it!

[rmartin16]

Ah, indeed; NoSubfolder is the correct value. Thanks for the PR.

This typo made it silently fail for me so maybe it would make sense to additionally check if a valid Literal was passed?

In general, I have avoided too much validation of the inputs and instead deferred to whatever qBittorrent does with bad inputs. This is mostly because it can be difficult to know accepted values....and when they change over time, it's difficult to then accurately represent the supported values to user of this API.

Nonetheless, this Literal will validate the value for devs using type checkers or IDEs with type checking enabled. So, I think that's far enough towards validating this value for users.

And it appears to make matters even more embarrassing for me.....I spelled the value correctly a little lower down and then told mypy to stop pestering me about it....lol

        if (
            content_layout is None
            and is_root_folder is not None
            and api_version >= v("2.7")
        ):
            content_layout = "Original" if is_root_folder else "NoSubfolder"  # type: ignore[assignment]

If you wouldn't mind removing # type: ignore[assignment], then CI will be able to proceed.

[DrRac27]

Nonetheless, this Literal will validate the value for devs using type checkers or IDEs with type checking enabled. So, I think that's far enough towards validating this value for users.

You are right, better keep it maintainable :)

And it appears to make matters even more embarrassing for me.....I spelled the value correctly a little lower down and then told mypy to stop pestering me about it....lol

Haha happens to all of us 😄

If you wouldn't mind removing # type: ignore[assignment], then CI will be able to proceed.

Done :)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (301acef) to head (56e17ce).
Report is 8 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##              main      #499   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        15           
  Lines         1844      1844           
  Branches       197       104   -93     
=========================================
  Hits          1844      1844           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[rmartin16]

thanks for the fix! definitely appreciate it.