Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LogSAS binning for 3pt correlations #165

Merged
merged 49 commits into from
Jan 4, 2024
Merged

Add LogSAS binning for 3pt correlations #165

merged 49 commits into from
Jan 4, 2024

Conversation

rmjarvis
Copy link
Owner

@rmjarvis rmjarvis commented Jan 2, 2024

The current binning for 3pt correlations is based on SSS definitions of triangles. I.e. the three side lengths. This has some advantages with regard to the tree descent, since side lengths are easy to calculate, but it has proven awkward for some applications where SAS binning is more scientifically relevant.

This PR adds LogSAS as a new bin type for 3pt correlations using SAS definitions of the triangles. This binning is in log(r) for two side lengths, and in phi, the angle between these two sides. This binning is particularly attractive for implementing the Philcox/Porth et al algorithm for 3pt correlations using a multipole expansion, where the SAS binning is more or less required.

Along the way, I realized a much nicer UI for doing directed cross correlations. Now rather than use the GGGCrossCorrelation class (and similar), the regular class's process method has a new option, ordered=True, which directs the code to keep the ordering of the three cells fixed during the tree traversal, rather than letting them change orientations. This is both more intuitive and often more efficient, since one will likely not usually want all 6 permutations, so the code will now skip a lot of unnecessary calculations when doing this.

@rmjarvis rmjarvis added this to the Version 5.0 milestone Jan 2, 2024
@rmjarvis rmjarvis merged commit 37f39a9 into main Jan 4, 2024
11 checks passed
@rmjarvis rmjarvis deleted the LogSAS branch January 4, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant