-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LogSAS binning for 3pt correlations #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…idden bugs they had allowed.
… no longer necessary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current binning for 3pt correlations is based on SSS definitions of triangles. I.e. the three side lengths. This has some advantages with regard to the tree descent, since side lengths are easy to calculate, but it has proven awkward for some applications where SAS binning is more scientifically relevant.
This PR adds LogSAS as a new bin type for 3pt correlations using SAS definitions of the triangles. This binning is in log(r) for two side lengths, and in phi, the angle between these two sides. This binning is particularly attractive for implementing the Philcox/Porth et al algorithm for 3pt correlations using a multipole expansion, where the SAS binning is more or less required.
Along the way, I realized a much nicer UI for doing directed cross correlations. Now rather than use the GGGCrossCorrelation class (and similar), the regular class's process method has a new option,
ordered=True
, which directs the code to keep the ordering of the three cells fixed during the tree traversal, rather than letting them change orientations. This is both more intuitive and often more efficient, since one will likely not usually want all 6 permutations, so the code will now skip a lot of unnecessary calculations when doing this.