-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch default 3pt to use LogSAS and ordered=True #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmjarvis
force-pushed
the
default_ordered
branch
from
January 14, 2024 15:13
300a247
to
cbe4252
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is more prep for the multipole algorithm. That algorithm will need to use LogSAS binning, not LogRUV, and since it is so much faster than the current 3 cell recursive algorithm, it makes sense to switch the default to be LogSAS. LogRUV is still available, but I don't expect most people to want to use it.
Also, I realized that the new
ordered=True
option to process is likely to be the version that most people will want for most applications. I think the only common use case that would prefer ordered=False is when doing data-random cross correlations, so I explicitly call out that case as an example in the docs.Finally, there are some other minor cleanup changes that I ran into when working on the multipole algorithm, so I'm putting them here to keep that PR as clean as possible.