Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch default 3pt to use LogSAS and ordered=True #166

Merged
merged 18 commits into from
Jan 14, 2024
Merged

Conversation

rmjarvis
Copy link
Owner

This is more prep for the multipole algorithm. That algorithm will need to use LogSAS binning, not LogRUV, and since it is so much faster than the current 3 cell recursive algorithm, it makes sense to switch the default to be LogSAS. LogRUV is still available, but I don't expect most people to want to use it.

Also, I realized that the new ordered=True option to process is likely to be the version that most people will want for most applications. I think the only common use case that would prefer ordered=False is when doing data-random cross correlations, so I explicitly call out that case as an example in the docs.

Finally, there are some other minor cleanup changes that I ran into when working on the multipole algorithm, so I'm putting them here to keep that PR as clean as possible.

@rmjarvis rmjarvis added this to the Version 5.0 milestone Jan 14, 2024
@rmjarvis rmjarvis merged commit 5867cc5 into main Jan 14, 2024
11 checks passed
@rmjarvis rmjarvis deleted the default_ordered branch January 14, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant