-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 2pt correlations of complex spin-0 fields using the letter Z #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmjarvis
force-pushed
the
zcorrelation
branch
5 times, most recently
from
March 6, 2024 04:15
d5ee8ca
to
1b2eed8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've recently added spin-1, spin-3 and spin-4 fields to TreeCorr. Spin-0 fields can be done using just multiple calls to NK or KK, but it seems worth having a letter for complex spin-0 fields for cases where that might be relevant. I don't have any specific use cases in mind. This is just for overall API consistency really.
The new implemented classes are NZCorrelation, KZCorrelation, and ZZCorrelation. If someone wants additional pairing of Z with G, T, or Q, let me know. It's not particularly hard, but I won't bother with those until someone requests it.