Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.0.0.a3 #58

Merged
merged 14 commits into from
Dec 6, 2023
Merged

Release 1.0.0.a3 #58

merged 14 commits into from
Dec 6, 2023

Conversation

rmnldwg
Copy link
Owner

@rmnldwg rmnldwg commented Dec 6, 2023

No description provided.

The `set_params()` method of the diagnose time distributions can now
raise a `ValueError` then and there, provided the provided
parametrization also throws a `ValueError` when invalid params are
provided.

Fixes: #53
Add a test to make sure a `ValueError` is raised inside the
`set_params()` of the diagnose time `Distribution`.

Related: #53
Inform the user via the documentation of the requirement to raise a
`ValueError` inside a parametric diagnose time distribution.

Related: #53
Since the model's `graph` attribute provides the `lnls` as dictionary,
we need to pass its keys if we want to have an iterable of their names.

Fixes: #56
@rmnldwg rmnldwg self-assigned this Dec 6, 2023
@rmnldwg rmnldwg merged commit d905b68 into main Dec 6, 2023
2 checks passed
@rmnldwg rmnldwg deleted the release-1.0.0.a3 branch December 6, 2023 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant