Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chaning config map to a configmap yaml file. #6

Open
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

rjhowe
Copy link

@rjhowe rjhowe commented Dec 15, 2022

So instead of running:

$ curl https://raw.githubusercontent.com/robbmanes/openshift4-debug/main/utilities/collectl/entrypoint.sh -o entrypoint.sh
$ oc create configmap collectl-entrypoint-test --from-file entrypoint.sh 

We can run the following with out needing to pull repo or use curl:

$ oc create -f https://raw.githubusercontent.com/robbmanes/openshift4-debug/main/utilities/collectl/configmap-entrypoint.yaml

@rjhowe
Copy link
Author

rjhowe commented Dec 15, 2022

No big deal if you think its better the other way :-)

@robbmanes
Copy link
Owner

Sorry I totally missed this. I think it probably best if we add both options. I'll do both shortly.

@robbmanes
Copy link
Owner

This is a big change, but appears to work fine in my test clusters. I have no CI/CD setup for this repo yet. Can you confirm this has worked in live environments @rjhowe ?

@robbmanes robbmanes self-assigned this Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants