Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Monmouthshire collection new line error #1104

Merged
merged 1 commit into from
Jan 4, 2025
Merged

Conversation

ffaen
Copy link
Contributor

@ffaen ffaen commented Dec 27, 2024

For Monmouthshire council, some collection date tags have new lines in them, therefore they must also be removed before parsing to check if the line starts with "Your next collection date is"

Just copied the text function from line 42, which already does this

image

Copy link

codecov bot commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.93%. Comparing base (7b4b6eb) to head (450c608).
Report is 35 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1104   +/-   ##
=======================================
  Coverage   71.93%   71.93%           
=======================================
  Files           9        9           
  Lines        1037     1037           
=======================================
  Hits          746      746           
  Misses        291      291           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ffaen ffaen changed the title Fix Monmouthshire collection new line error fix: Fix Monmouthshire collection new line error Jan 3, 2025
@ffaen ffaen changed the title fix: Fix Monmouthshire collection new line error Fix Monmouthshire collection new line error Jan 3, 2025
@robbrad robbrad merged commit 3a44818 into robbrad:master Jan 4, 2025
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants