Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Hart District Council #1116

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

Dan-baker
Copy link

Proposed feature to add support for Hart District Council (requested here: Fleet, Hart Council #1038)

@Dan-baker Dan-baker mentioned this pull request Jan 2, 2025
4 tasks
Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.93%. Comparing base (7b4b6eb) to head (3c3df5f).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1116   +/-   ##
=======================================
  Coverage   71.93%   71.93%           
=======================================
  Files           9        9           
  Lines        1037     1037           
=======================================
  Hits          746      746           
  Misses        291      291           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dp247
Copy link
Collaborator

dp247 commented Jan 2, 2025

For future reference, you can use action words to automatically link your PR to an issue and close on merge - see here 😊

@Dan-baker Dan-baker force-pushed the 1083-hart-district-council branch from ced60b7 to a11546b Compare January 2, 2025 16:25
@Dan-baker Dan-baker force-pushed the 1083-hart-district-council branch from a11546b to 3c3df5f Compare January 2, 2025 16:28
@Dan-baker
Copy link
Author

For future reference, you can use action words to automatically link your PR to an issue and close on merge - see here 😊

Super! Thanks. I was sure that there must be a better way of doing that! 😄

@Dan-baker
Copy link
Author

Squashed commits in order to fix the commit message linting issue.

@Dan-baker
Copy link
Author

I could do with a hand from someone more familiar with this project to understand the test failures. Looks like the tests passed and then failed to be archived?

@dp247
Copy link
Collaborator

dp247 commented Jan 2, 2025

I could do with a hand from someone more familiar with this project to understand the test failures. Looks like the tests passed and then failed to be archived?

Don't worry about it for now, the repo's allure reports are broken so it fails atm

@robbrad
Copy link
Owner

robbrad commented Jan 2, 2025

I could do with a hand from someone more familiar with this project to understand the test failures. Looks like the tests passed and then failed to be archived?

Don't worry about it for now, the repo's allure reports are broken so it fails atm

I'm gonna take a look at this tomorrow team

@robbrad robbrad merged commit cf27d59 into robbrad:master Jan 2, 2025
13 of 14 checks passed
@dp247
Copy link
Collaborator

dp247 commented Jan 2, 2025

I could do with a hand from someone more familiar with this project to understand the test failures. Looks like the tests passed and then failed to be archived?

Don't worry about it for now, the repo's allure reports are broken so it fails atm

I'm gonna take a look at this tomorrow team

You're a superstar! 🌟

@robbrad
Copy link
Owner

robbrad commented Jan 4, 2025

@dp247 : integration reports fixed

Nightly Full Integration Test Reports:

[3.12 Full](https://robbrad.github.io/UKBinCollectionData/3.12/full)

Partial Pull Request Test Reports

[3.12 Partial](https://robbrad.github.io/UKBinCollectionData/3.12/partial)

@dp247
Copy link
Collaborator

dp247 commented Jan 4, 2025

YESSSSSS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants