Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly handle year increment for January dates (Broxbourne Council) #1119

Merged
merged 1 commit into from
Jan 4, 2025

Conversation

teofanis
Copy link
Contributor

@teofanis teofanis commented Jan 3, 2025

I've missed this in my previous PR.

The council's dates are provided in day/month format, and the script was incrementing the year if the current month was January. This worked fine for December or November but caused issues when viewing dates in January.

I've updated the script to increment the year for January dates only when parsed in a month other than January.

Copy link

codecov bot commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.93%. Comparing base (2554e6e) to head (0bef678).
Report is 26 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1119   +/-   ##
=======================================
  Coverage   71.93%   71.93%           
=======================================
  Files           9        9           
  Lines        1037     1037           
=======================================
  Hits          746      746           
  Misses        291      291           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robbrad robbrad merged commit c1654ec into robbrad:master Jan 4, 2025
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants