Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update bin type to be the full string #1161

Merged
merged 1 commit into from
Jan 13, 2025
Merged

fix: Update bin type to be the full string #1161

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions uk_bin_collection/uk_bin_collection/councils/SouthOxfordshireCouncil.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ def parse_data(self, page: str, **kwargs) -> dict:
"%A %d %B - %Y",
)
).strftime(date_format)
bin_type = str.capitalize(bin_info[1])
bin_type = str.capitalize(' '.join(bin_info[1:]))
# On exceptional collection schedule (e.g. around English Bank Holidays), date will be contained in the second stripped string
else:
bin_date = get_next_occurrence_from_day_month(
Expand All @@ -75,7 +75,7 @@ def parse_data(self, page: str, **kwargs) -> dict:
"%A %d %B - %Y",
)
).strftime(date_format)
bin_type = str.capitalize(bin_info[2])
str.capitalize(' '.join(bin_info[2:]))
except Exception as ex:
raise ValueError(f"Error parsing bin data: {ex}")

Expand Down
Loading