fix: Home Assistant custom component fix for Selenium based councils #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## master #397 +/- ##
==========================================
- Coverage 83.44% 80.24% -3.20%
==========================================
Files 3 3
Lines 151 162 +11
==========================================
+ Hits 126 130 +4
- Misses 25 32 +7
|
OliverCullimore
added
python
robbrad
approved these changes
Oct 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully closes #381
Implements webdriver_manager to auto-install the Chrome driver and return the path to it for Selenium to use
Moved the creation of the webdriver to a common function as part of this also to reduce code duplication and make any necessary updates in future easier