Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GIF image type support in PDF mode? #13

Open
hantsaniala opened this issue Oct 11, 2024 · 4 comments
Open

GIF image type support in PDF mode? #13

hantsaniala opened this issue Oct 11, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@hantsaniala
Copy link

Is your feature request related to a problem? Please describe.
Sometimes, some chapters are in GIF format and are skipped when downloading. So some books end up without a single content inside.

Describe the solution you'd like
Support GIF format for PDF export.

Describe alternatives you've considered
CBZ format doesn't have this problem, but the page content is not right.

Additional context
OS: Ubuntu 24.04.1
Go: Go 1.22.2

Example URL: https://www.webtoons.com/en/slice-of-life/murrz/ep-226-devil-flowers/viewer?title_no=1281&episode_no=226

CBZ glitch
image

@hantsaniala hantsaniala added the enhancement New feature or request label Oct 11, 2024
@robinovitch61
Copy link
Owner

Thanks for this feature request @hantsaniala! Would you want to have a go at adding the feature yourself and making a pull request to get it in the next release? I'm a bit tied up with work and other projects.

If you want a hand getting set up for making a code change in this repo, I can add a CONTRIBUTING file with further guidance, LMK!

@hantsaniala
Copy link
Author

I was about to make a PR for the PDF but stuck with some logic that I'm little bit lost. import _ "image/gif" fix the unknown type error but I still have blank page problem using c.pdf.ImageByHolder(). Any hint to how to fix this? I'll PR if I found a solution.

@robinovitch61
Copy link
Owner

If you open a draft PR with your attempt so far, I can take a look at it when I get some time!

@hantsaniala
Copy link
Author

Here please. I'm still looking for solution but if you can hint me where to go, I can fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants