Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RemoteEvent ancestor class #1087

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Fix RemoteEvent ancestor class #1087

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/customDefinitions.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -756,7 +756,7 @@ interface PolicyService extends Instance {
GetPolicyInfoForPlayerAsync(this: PolicyService, player: Player): PolicyInfo;
}

interface RemoteEvent<T extends Callback = Callback> extends Instance {
interface RemoteEvent<T extends Callback = Callback> extends BaseRemoteEvent {
readonly OnClientEvent: RBXScriptSignal<T>;
/** The reason we DON'T allow you to use `Parameters<T>` here is because you can't trust data from the client. Please type-check and sanity-check all values received from the client. E.g. if you are expecting a number from the client, you should check whether the received value is indeed a number and you might also want to make sure it isn't a `NaN` value. See example code:
* ```ts
Expand Down
Loading