-
-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow configuring arbitrary gain settings #546
Conversation
This looks pretty good! The only thing I can think that is missing is that the gain values are not really saved anywhere in the source. I might add a little code that creates a vector of the gain values. This could be useful for sending the config of the Source off to somewhere else. |
Ok - I have gone a bit off the deep end and I am reworking the whole gain section to be based on around this... Mostly just changes under the hood. |
That looks pretty good to me! I guess at some point you'll want to remove the non-array config options there, but no real reason to break backwards compatibility now. |
Agreed - I am just keeping the old way around for compatibility, but it could all be moved to the settings array. Thanks for putting this together!! |
just wanted to say, I tested it and appears to have fixed issues I was having with a bladeRF x40 where gains weren't being set properly, they appear to set perfectly fine now... the bladeRF 2.0 xA9 on the other hand, I think might be totally useless in its ability to set gains but that's their fault, not yours... before:
after (using gainSettings and lowercase "lna" plus the other two differently named gain settings):
no errors at all! nice! |
This adds a "gain_settings" option to sources, which allows you to configure arbitrary gain stages by name. For example, to fix some of the RSP1A issues from #422:
I am not a C developer, so uh.. you get to keep both pieces if this breaks. I did not remove any of the existing gain config settings - these will override anything set in this new array.