Adding support for SpyServer to Dockerfile #797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(need to fix CI, apparently) |
|
Ugh! This looks like some weird build bug for gr-osmosdr. |
|
ACtually - it may have nothing to do with a change you made and was a separate that was fixed. Could you make some sort of trivial change that would retrigger the build? |
EricTendian
force-pushed
the
osmosdr-improvements
branch
from
85374ad
to
876d199
Compare
|
@robotastic this was an issue with my changes to the gr-osmosdr fork, I submitted a PR to that repo which will fix the issue, and then I'll be able to rebase and open this PR up again. |
EricTendian
force-pushed
the
osmosdr-improvements
branch
2 times, most recently
from
674199b
to
f38b158
Compare
EricTendian
force-pushed
the
osmosdr-improvements
branch
from
f38b158
to
75a813c
Compare
EricTendian
changed the title
|
@robotastic this is finally ready for a review now that the gr-osmosdr fork has been updated. I ended up taking out the SDRPlay changes since that's technically already available in gr-osmosdr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a few improvements to the Dockerfile by adding support for SpyServer, via a fork of gr-osmosdr. I just submitted a PR to it which got it back in sync with the upstream repo, as well as added the AirSpy serial number patch, so we no longer need to do that as part of the build process (which is why I'm removing the patch).
This should allow the Docker setup to have support for even more SDRs.