Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RecordUnknown behaviors #842

Merged
merged 2 commits into from
Oct 23, 2023
Merged

Conversation

taclane
Copy link
Contributor

@taclane taclane commented Aug 17, 2023

The monitoring state UNKNOWN_TG is currently unused, and appears to exist to flag calls that will not be recorded if "recordUnknown": false is set in a system config and the talkgroup cannot be found in the .csv.

The setting hideUnknownTalkgroups currently does nothing as the only use in trunk-recorder is commented out. Per the documents, the expected logging behavior should be:

Key Required Default Value Type Description
hideUnknownTalkgroups false true / false Hide unknown talkgroups log entries

This small patch will flag a monitoring state when unknown talkgroups will not be recorded, and restore messages like the below unless otherwise configured:

(info)   [name]  6C  TG: 12345 (  -)  Freq: 774.606250 MHz  Not Recording: TG not in Talkgroup File

@robotastic
Copy link
Owner

Good catch! I am not quite sure why that got commented out

@robotastic robotastic merged commit 01f3f62 into robotastic:master Oct 23, 2023
1 check passed
@taclane taclane deleted the unknown-tg branch November 16, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants