Capture P25 RFSS and Site ID information. #846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robotastic
reviewed
Nov 5, 2023
trunk-recorder/main.cc
Outdated
| @@ -951,6 +951,14 @@ void current_system_status(TrunkMessage message, System *sys) { | |||
| } | |||
| } | |||
|
|
|||
| void current_system_sysid(TrunkMessage message, System *sys) { | |||
| if ((sys->get_system_type() == "p25") || (sys->get_system_type() != "conventionalP25")) { | |||
There was a problem hiding this comment.
Should this be != "conventionalP25"? Since this is an OR, it seems like it would be true for every system type, except for "conventionalP25
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Store P25 RFSS and Site ID in the system object and display them on initial decode. This should help with optimizing deduplication and other future enhancements.