Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't remove call when upload failed #939

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rosecitytransit
Copy link
Contributor

No description provided.

@taclane
Copy link
Contributor

taclane commented Mar 21, 2024

I don't know if there's an easy way to accomplish this without creating a new archiveFailedUploads config option, but just leaving the files in place might cause other issues.

The concern that comes to mind is that the default tempDir attempts to use a RAM-based filesystem. An extended network outage is likely to break trunk-recorder, or degrade the whole system, if it isn't cleaning up after calls.

@rosecitytransit
Copy link
Contributor Author

That is a good point. Certainly an ongoing network issue (could be a configuration issue or OpenMHz/Broacastify issue too) could fill things up and cause havoc. For those who don't really have any local storage there may not be a place to put files that are in limbo. But it just seems bad to immediately, permanently delete things that haven't been successfully processed.

FWIW, the call that I was after was a 4015-second long open mic transmission that I had heard on my personal scanner but OpenMHz rejected it for being too large. One idea to handle that issue would be to have the maxDuration parameter apply to trunked as well as to conventional calls.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants