Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for CRDs #76

Merged
merged 6 commits into from
Aug 18, 2024
Merged

add support for CRDs #76

merged 6 commits into from
Aug 18, 2024

Conversation

aantn
Copy link
Collaborator

@aantn aantn commented May 16, 2024

Tests performed:

  • tested for the current version of runner

@Colvin-Y
Copy link

Colvin-Y commented Jun 27, 2024

@aantn Could you please add helm rbac relaed templates modified interface in helm values.yaml?
Then user can just use helm upgrade to watch their own resources.

@JASenpai
Copy link

this would be so useful

@aantn
Copy link
Collaborator Author

aantn commented Aug 4, 2024

Hey, we haven't done it yet but please feel free to open a PR which builds upon this one and adds it.

@guettli
Copy link

guettli commented Aug 14, 2024

@aantn I would like to watch CRDs. How can I help to get the PR merged?

@arikalon1
Copy link
Collaborator

hey @guettli

We're actually working now on merging it
I think it will be merged within a week or so

@itisallgood itisallgood mentioned this pull request Aug 14, 2024
Copy link
Collaborator

@arikalon1 arikalon1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arikalon1 arikalon1 merged commit 80907c6 into master Aug 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants