Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with StreamID 0 #85

Open
jojo61 opened this issue Jan 2, 2024 · 2 comments
Open

Problem with StreamID 0 #85

jojo61 opened this issue Jan 2, 2024 · 2 comments

Comments

@jojo61
Copy link

jojo61 commented Jan 2, 2024

My EXIP 418 uses StreamID 0 right after a reboot. Then the plugin does not send the pidlist.
Here is a patch to correct the handling of streamid 0:

diff --git a/tuner.c b/tuner.c
index be7b392..d7c7b27 100644
--- a/tuner.c
+++ b/tuner.c
@@ -500,7 +500,7 @@ bool cSatipTuner::UpdatePids(bool forceP)
debug16("%s (%d) tunerState=%s [device %d]", PRETTY_FUNCTION, forceP, TunerStateString(currentStateM), deviceIdM);
cMutexLock MutexLock(&mutexM);
if (((forceP && pidsM.Size()) || (pidUpdateCacheM.TimedOut() && (addPidsM.Size() || delPidsM.Size()))) &&
-- !isempty(*streamAddrM) && (streamIdM > 0)) {
++ !isempty(*streamAddrM) && (streamIdM >= 0)) {
cString uri = cString::sprintf("%sstream=%d", *GetBaseUrl(*streamAddrM, streamPortM), streamIdM);
bool useci = (SatipConfig.GetCIExtension() && currentServerM.HasCI());
bool usedummy = currentServerM.IsQuirk(cSatipServer::eSatipQuirkPlayPids);
@@ -600,7 +600,7 @@ bool cSatipTuner::ReadReceptionStatus(bool forceP)
statusUpdateM.Set(eStatusUpdateTimeoutMs);
forceP = true;
}
-- if (forceP && !isempty(*streamAddrM) && (streamIdM > 0)) {
++ if (forceP && !isempty(*streamAddrM) && (streamIdM >= 0)) {
cString uri = cString::sprintf("%sstream=%d", *GetBaseUrl(*streamAddrM, streamPortM), streamIdM);
if (rtspM.Describe(*uri))
return true;

@madmartin
Copy link
Contributor

Hello @jojo61 ,
how does the problem manifest itself in the vdr?
I own a EXIP414/e and wondering if it has the same problem.

@wirbel-at-vdr-portal
Copy link
Contributor

@madmartin, the first stream gets streamID = 0 for this SAT>IP server and is not handled by UpdatePids. Any other following stream works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants