Unsubscribe all Rails built-in subscribers #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes roidrage#385 Assumes that a built-in subscriber is nested under the component namespace, so under ActionView or ActionController.
owst
commented
Jan 24, 2024
| end | ||
|
|
||
| it 'removes subscribers for all events' do | ||
| expect do | ||
| Lograge.remove_existing_log_subscriptions | ||
| end.to change { | ||
| Lograge.notification_listeners_for('render_template.action_view') | ||
| } | ||
| }.to([]) |
There was a problem hiding this comment.
This spec failed after this change on Rails 7.1
owst
commented
Jan 24, 2024
| it "does not remove subscribers that aren't from Rails" do | ||
| proc_subscriber = ActiveSupport::Notifications.subscribe(event_name, proc {}) | ||
| custom_subscriber = | ||
| ActiveSupport::Notifications.subscribe(event_name, CustomListener.new) |
There was a problem hiding this comment.
Also check a custom class, in case there was some special handling of Proc instances
owst
commented
Jan 24, 2024
| delegate = listener.instance_variable_get('@delegate') | ||
|
|
||
| # Assume that anything nested under the component namespace is built in to Rails | ||
| delegate.class.name.start_with?("#{component.to_s.classify}::") |
There was a problem hiding this comment.
I don't think this is great, but I can't see a better way to check if the delegate is subscriber or (for Rails 7.1+) an instance of ActionView::LogSubscriber::Start for ActionView or subscriber for ActionController
owst
changed the title
|
Hey any progress on this? I'm using the branch in production to help our logs. Would love to see this merged. Anything I can help with? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #385
Assumes that a built-in subscriber is nested under the component namespace, so under ActionView or ActionController.