-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add children roSGNode containers #192
Conversation
…ion of temparory variables a helper function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few changes:
- Let's align with a new convention of
$
instead of[[ ]]
, (so$count
) - only add these virtual variables if the protocol version is
<3.3
It might make sense to add a helper function or separate file/class to manage these, as I expect we'll be adding more of them in the future. That way the getVariablesResponse
doesn't get too large.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good! One comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great!
Adds virtual variables for
$count
and$children
forroSGNode
and$count
for arrays.