Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add children roSGNode containers #192

Merged
merged 24 commits into from
Dec 3, 2024
Merged

Conversation

Christian-Holbrook
Copy link
Collaborator

@Christian-Holbrook Christian-Holbrook commented Jun 13, 2024

Adds virtual variables for $count and $children for roSGNode and $count for arrays.

image

Copy link
Member

@TwitchBronBron TwitchBronBron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few changes:

  • Let's align with a new convention of $ instead of [[ ]], (so $count)
  • only add these virtual variables if the protocol version is <3.3

It might make sense to add a helper function or separate file/class to manage these, as I expect we'll be adding more of them in the future. That way the getVariablesResponse doesn't get too large.

Copy link
Member

@TwitchBronBron TwitchBronBron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good! One comment.

src/adapters/DebugProtocolAdapter.ts Show resolved Hide resolved
Copy link
Member

@TwitchBronBron TwitchBronBron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

@TwitchBronBron TwitchBronBron merged commit cc32b3c into master Dec 3, 2024
6 checks passed
@TwitchBronBron TwitchBronBron deleted the evaluate-roSGNode-Children branch December 3, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants