Skip to content

Commit

Permalink
Pass the modal property from the PopupMessageEvent (#537)
Browse files Browse the repository at this point in the history
* Pass the modal property from the PopupMessageEvent

* Update to latest roku -debug
  • Loading branch information
Christian-Holbrook authored Jan 8, 2024
1 parent c7c3343 commit c9a9079
Show file tree
Hide file tree
Showing 3 changed files with 29 additions and 29 deletions.
50 changes: 25 additions & 25 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@
"node-ssdp": "^4.0.0",
"postman-request": "^2.88.1-postman.32",
"pretty-bytes": "^5.6.0",
"roku-debug": "^0.20.14",
"roku-debug": "^0.20.15",
"roku-deploy": "^3.11.1",
"roku-test-automation": "2.0.0-beta.22",
"semver": "^7.1.3",
Expand Down
6 changes: 3 additions & 3 deletions src/LogOutputManager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ export class LogOutputManager {
this.appendLine(e.body.line);

} else if (isPopupMessageEvent(e)) {
this.showMessage(e.body.message, e.body.severity);
this.showMessage(e.body.message, e.body.severity, e.body.modal);

} else if (isLaunchStartEvent(e)) {
this.isInMicroDebugger = false;
Expand All @@ -244,13 +244,13 @@ export class LogOutputManager {
}
}

private showMessage(message: string, severity: string) {
private showMessage(message: string, severity: string, modal: boolean) {
const methods = {
error: vscode.window.showErrorMessage,
info: vscode.window.showInformationMessage,
warn: vscode.window.showWarningMessage
};
methods[severity](message);
methods[severity](message, { modal: modal });
}

/**
Expand Down

0 comments on commit c9a9079

Please sign in to comment.