Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: test using the same storage key for default modules #225

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

Reecepbcups
Copy link
Member

@Reecepbcups Reecepbcups commented Oct 1, 2024

ref: cosmos/cosmos-sdk#21182

Summary

I goofed and shared the same service key (for new modules created) across all modules. using the proper namespaced service key resolve some issues found. Unit test for the nameservice module were run and functioned as expected.

@Reecepbcups Reecepbcups marked this pull request as ready for review October 1, 2024 21:42
@Reecepbcups Reecepbcups merged commit 66d057b into release/v0.50 Oct 1, 2024
9 checks passed
@Reecepbcups Reecepbcups deleted the reece/fix-collection-iter-in-unit-test branch October 1, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant