-
-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Mentor Task Reviews - Assign reviewer #2520
Conversation
π¦ Next.js Bundle AnalysisThis analysis was generated by the next.js bundle analysis action π€ Fifty-eight Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 5% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored. |
@Post('/') | ||
@ApiOperation({ operationId: 'assignReviewer' }) | ||
@ApiOkResponse({}) | ||
@RequiredRoles([CourseRole.Dementor, CourseRole.Manager, Role.Admin], true) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's make this functionality available only to managers and admins. The role of Dementors should only have the ability to view who has checked. And on the frontend, the button should also be accessible only to admins and managers.
π’ Add
deploy
label if you want to deploy this Pull Request to staging environmentπ§ββοΈ Pull Request Naming Convention
area:*
label(s)π€ This is a ...
π Related issue link
@valerydluski
π‘ Background and solution
βοΈ Self Check before Merge