Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Mentor Task Reviews - Assign reviewer #2520

Merged
merged 6 commits into from
Aug 5, 2024

Conversation

nataliagulko
Copy link
Contributor

🟒 Add deploy label if you want to deploy this Pull Request to staging environment

πŸ§‘β€βš–οΈ Pull Request Naming Convention

  • Title should follow Conventional Commits
  • Do not put issue id in title
  • Do not put WIP in title. Use Draft PR functionality
  • Consider to add area:* label(s)
  • I followed naming convention rules

πŸ€” This is a ...

  • New feature
  • Bug fix
  • Performance optimization
  • Refactoring
  • Test Case
  • Documentation update
  • Other

πŸ”— Related issue link

@valerydluski

πŸ’‘ Background and solution

  • Add possibility to assign reviewer

β˜‘οΈ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Database migration is added or not needed
  • Documentation is updated/provided or not needed
  • Changes are tested locally

Copy link

github-actions bot commented Aug 2, 2024

πŸ“¦ Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action πŸ€–

Fifty-eight Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (500 KB)
/ 295.22 KB 406.7 KB 81.34% (🟑 +0.01%)
/404 229.88 KB 341.36 KB 68.27% (🟑 +0.01%)
/admin/courses 390.89 KB 502.37 KB 100.47% (🟑 +0.01%)
/admin/disciplines 335.88 KB 447.35 KB 89.47% (🟑 +0.01%)
/admin/discord-server 362.63 KB 474.11 KB 94.82% (🟑 +0.01%)
/admin/events 363.28 KB 474.76 KB 94.95% (🟑 +0.01%)
/admin/mentor-registry 388.43 KB 499.91 KB 99.98% (🟑 +0.01%)
/admin/notifications 404.12 KB 515.6 KB 103.12% (🟑 +0.20%)
/admin/prompts 343.16 KB 454.64 KB 90.93% (🟑 +0.01%)
/admin/registrations 335.6 KB 447.07 KB 89.41% (🟑 +0.01%)
/admin/students 351.39 KB 462.87 KB 92.57% (🟑 +0.01%)
/admin/tasks 435.94 KB 547.41 KB 109.48% (🟑 +0.01%)
/admin/user-group 387.6 KB 499.08 KB 99.82% (+/- <0.01%)
/admin/users 277.85 KB 389.32 KB 77.86% (🟑 +0.01%)
/applicants 318.48 KB 429.96 KB 85.99% (🟑 +0.01%)
/course/admin/certified-students 175.74 KB 287.21 KB 57.44% (🟑 +0.01%)
/course/admin/cross-check-table 463.52 KB 574.99 KB 115.00% (🟑 +0.01%)
/course/admin/events 446.92 KB 558.4 KB 111.68% (🟑 +0.20%)
/course/admin/interviews 386.55 KB 498.02 KB 99.60% (🟑 +0.01%)
/course/admin/mentor-tasks-review 404.07 KB 515.54 KB 103.11% (πŸ”΄ +13.71%)
/course/admin/mentors 391.06 KB 502.54 KB 100.51% (🟑 +0.01%)
/course/admin/stage-interviews 388.22 KB 499.7 KB 99.94% (🟑 +0.01%)
/course/admin/students 399.67 KB 511.14 KB 102.23% (🟑 +0.01%)
/course/admin/tasks 419.45 KB 530.93 KB 106.19% (+/- <0.01%)
/course/admin/users 386.25 KB 497.73 KB 99.55% (+/- <0.01%)
/course/interview/[type]/feedback 350.44 KB 461.92 KB 92.38% (🟑 +0.01%)
/course/mentor/auto-confirm 232.17 KB 343.65 KB 68.73% (🟑 +0.01%)
/course/mentor/confirm 298.99 KB 410.46 KB 82.09% (🟑 +0.01%)
/course/mentor/dashboard 406.83 KB 518.31 KB 103.66% (🟑 +0.01%)
/course/mentor/expel-student 302.94 KB 414.41 KB 82.88% (🟑 +0.01%)
/course/mentor/feedback 305.44 KB 416.92 KB 83.38% (🟑 +0.01%)
/course/mentor/interview-technical-screening 271.23 KB 382.7 KB 76.54% (🟑 +0.01%)
/course/mentor/interview-wait-list 344.09 KB 455.56 KB 91.11% (🟑 +0.01%)
/course/mentor/interviews 355.14 KB 466.62 KB 93.32% (🟑 +0.01%)
/course/mentor/students 261.25 KB 372.72 KB 74.54% (🟑 +0.01%)
/course/schedule 489.35 KB 600.82 KB 120.16% (🟑 +0.20%)
/course/score 343.91 KB 455.38 KB 91.08% (🟑 +0.01%)
/course/stats 291.75 KB 403.23 KB 80.65% (+/- <0.01%)
/course/student/auto-test 396.93 KB 508.41 KB 101.68% (🟑 +0.01%)
/course/student/auto-test/task 396.85 KB 508.32 KB 101.66% (🟑 +0.01%)
/course/student/cross-check-review 488.18 KB 599.65 KB 119.93% (🟑 +0.01%)
/course/student/cross-check-submit 468.05 KB 579.53 KB 115.91% (+/- <0.01%)
/course/student/dashboard 403.57 KB 515.05 KB 103.01% (🟑 +0.01%)
/course/student/interviews 309 KB 420.47 KB 84.09% (🟑 +0.01%)
/course/submit-scores 419.33 KB 530.81 KB 106.16% (🟑 +0.01%)
/course/team-distributions 390.27 KB 501.75 KB 100.35% (🟑 +0.49%)
/course/teams 436.73 KB 548.2 KB 109.64% (🟑 +0.49%)
/cv/[uuid] 249.48 KB 360.96 KB 72.19% (🟑 +0.01%)
/cv/edit 353.87 KB 465.34 KB 93.07% (🟑 +0.01%)
/gratitude 297.38 KB 408.86 KB 81.77% (🟑 +0.01%)
/heroes 403.58 KB 515.06 KB 103.01% (🟑 +0.01%)
/job 175.83 KB 287.3 KB 57.46% (🟑 +0.01%)
/profile 415.14 KB 526.62 KB 105.32% (🟑 +0.01%)
/profile/connection-confirmed 271.38 KB 382.86 KB 76.57% (🟑 +0.01%)
/profile/notifications 337 KB 448.47 KB 89.69% (🟑 +0.01%)
/registry/epamlearningjs 298.39 KB 409.87 KB 81.97% (🟑 +0.01%)
/registry/mentor 348.36 KB 459.83 KB 91.97% (+/- <0.01%)
/registry/student 348.35 KB 459.83 KB 91.97% (+/- <0.01%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 5% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@Post('/')
@ApiOperation({ operationId: 'assignReviewer' })
@ApiOkResponse({})
@RequiredRoles([CourseRole.Dementor, CourseRole.Manager, Role.Admin], true)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make this functionality available only to managers and admins. The role of Dementors should only have the ability to view who has checked. And on the frontend, the button should also be accessible only to admins and managers.

@nataliagulko nataliagulko merged commit 434f656 into master Aug 5, 2024
6 checks passed
@nataliagulko nataliagulko deleted the feat/mentor-reviews-assign-reviewer branch August 5, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants