Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add cross-check review status message #2568

Conversation

asfound
Copy link
Contributor

@asfound asfound commented Dec 25, 2024

🟒 Add deploy label if you want to deploy this Pull Request to staging environment

πŸ§‘β€βš–οΈ Pull Request Naming Convention

  • Title should follow Conventional Commits
  • Do not put issue id in title
  • Do not put WIP in title. Use Draft PR functionality
  • Consider to add area:* label(s)
  • I followed naming convention rules

πŸ€” This is a ...

  • New feature
  • Bug fix
  • Performance optimization
  • Refactoring
  • Test Case
  • Documentation update
  • Other

πŸ”— Related issue link

Issue 2553

πŸ’‘ Background and solution

Background:

When the cross-check starts, in the Cross-Check: Submit tab, in the section where reviewers’ messages appear, there was no clear indication if no one has reviewed the work.

Solution:

  1. Added a status image and message: "No one has checked your work yet."
    This is displayed when Cross-check has started, but no reviews have been submitted.

  2. Added a status image and message: "No one has checked your work. Check if you are eligible to appeal here."
    This is shown when Cross-check has ended, and no reviews were submitted. The message includes a link to the appeal section of the Cross-check flow in the school documentation.

Test-tasks cases

  • Cross-check not started, submit possible: status not shown.

  • Cross-check ongoing, review present: status not shown.

  • Cross-check ongoing, no review: status shown.

  • Cross-check ended, no review: status and link to appeal shown.

  • Cross-check ended, no submit: status not shown.

Test tasks demonstration

β˜‘οΈ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Database migration is added or not needed
  • Documentation is updated/provided or not needed
  • Changes are tested locally

@valerydluski valerydluski linked an issue Dec 25, 2024 that may be closed by this pull request
@asfound asfound changed the title Feature/cross check review status message feat: add cross-check review status message Dec 25, 2024
@asfound asfound marked this pull request as ready for review December 25, 2024 15:20
@asfound asfound force-pushed the feature/cross-check-review-status-message branch from 7e02521 to 95c1a6a Compare December 25, 2024 15:21
@valerydluski valerydluski merged commit e916ed2 into rolling-scopes:master Dec 28, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display a status message in the Cross-Check Submit tab
3 participants