Merge pull request #22 from courseload/fix-tabindex-0

Ensure elements with a tabIndex is set to 0 are considered interactive.
romeovs · May 12, 2015 · 870237a · 870237a
2 parents 069ab87 + f33cb44
commit 870237a
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/lib/__tests__/index-test.js b/lib/__tests__/index-test.js
@@ -137,6 +137,12 @@ describe('props', () => {
           <div onClick={k} tabIndex="0"/>;
         });
       });
+
+      it('does not warn when tabIndex is present', () => {
+        doNotExpectWarning(assertions.props.onClick.NO_TABINDEX.msg, () => {
+          <div onClick={k} tabIndex={0}/>;
+        });
+      });
     });
 
     describe('when element is interactive', () => {

diff --git a/lib/assertions.js b/lib/assertions.js
@@ -51,7 +51,7 @@ exports.props = {
       test (tagName, props, children) {
         return !(
           !isInteractive(tagName, props) &&
-          !props.tabIndex
+          props.tabIndex == null // tabIndex={0} is valid
         );
       }
     },