Skip to content

Commit

Permalink
[fixed] Issue where label assertion returns a false negative when lab…
Browse files Browse the repository at this point in the history
…el is inside a child Component (fixes reactjs#44)

[added] Tests to ensure anchors with a tabIndex but without an href require an ARIA button role (fixes reactjs#45)
[added] selection and option to the list of interactive elements that require labels
[removed] getFailures() method since all failures are now logged asynchronously
  • Loading branch information
Todd Kloots committed Jun 8, 2015
1 parent b632b14 commit c4d52fc
Show file tree
Hide file tree
Showing 11 changed files with 593 additions and 218 deletions.
3 changes: 3 additions & 0 deletions .travis.yml
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
language: node_js
node_js:
- "0.10"
before_script:
- export DISPLAY=:99.0
- sh -e /etc/init.d/xvfb start
2 changes: 0 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,6 @@ always be in sync.
### Development

- `npm test` will fire up a karma test runner and watch for changes
- `npm run examples` fires up a webpack dev server that will watch
for changes and build the examples

### Build

Expand Down
6 changes: 0 additions & 6 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -58,12 +58,6 @@ use the `includeSrcNode` option.
a11y(React, { throw: true, includeSrcNode: true });
```

All failures are also accessible via the `getFailures()` method.

```
a11y.getFailures();
```

Some test are only relevant for certain device types. For example,
if you are building a mobile web app, you can filter out
desktop-specific rules by specifying a specific device type:
Expand Down
43 changes: 43 additions & 0 deletions karma.conf.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
var webpack = require('webpack');

module.exports = function (config) {
config.set({

browserNoActivityTimeout: 30000,

browsers: [ process.env.CONTINUOUS_INTEGRATION ? 'Firefox' : 'Chrome' ],

singleRun: process.env.CONTINUOUS_INTEGRATION === 'true',

frameworks: [ 'mocha' ],

files: [
'tests.webpack.js'
],

preprocessors: {
'tests.webpack.js': [ 'webpack', 'sourcemap' ]
},

reporters: [ 'dots' ],

webpack: {
devtool: 'inline-source-map',
module: {
loaders: [
{ test: /\.js$/, loader: 'babel-loader' }
]
},
plugins: [
new webpack.DefinePlugin({
'process.env.NODE_ENV': JSON.stringify('test')
})
]
},

webpackServer: {
noInfo: true
}

});
};
Loading

0 comments on commit c4d52fc

Please sign in to comment.