Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Command Line Interface #1

Open
21 of 25 tasks
romibi opened this issue Jan 7, 2022 · 12 comments
Open
21 of 25 tasks

Create Command Line Interface #1

romibi opened this issue Jan 7, 2022 · 12 comments
Labels
enhancement New feature or request

Comments

@romibi
Copy link
Owner

romibi commented Jan 7, 2022

Things to do for the Command Line Interface

  • define cli arguments
  • list files/folders
  • add
    • file to new
    • file to existing
    • replace file in existing
    • folder to new
    • folder to existing
  • remove
    • file
    • folder
  • extract
    • file
    • folder
  • rename
    • file
    • folder
  • support multipart archive files
  • search content (maybe)
  • copy file between packed (maybe)
  • copy folder between packed (maybe)
@Strongleong
Copy link
Collaborator

Now with -s and -f I think this one done

  • show additional info (properly)

@romibi romibi added the enhancement New feature or request label Jan 14, 2022
@romibi romibi added this to the Basic CLI tasks finished milestone Oct 17, 2023
@romibi
Copy link
Owner Author

romibi commented Oct 17, 2023

@Strongleong

  • tree structure

This you wanted me to implement, right?

And:

  • support multipart archive files

How's the status of this?

Evaluating if the remaining tasks here should get their own issues and this issue be closed.

@Strongleong
Copy link
Collaborator

  • tree structure

This you wanted me to implement, right?

I couldn't implement this with our current way of storing list of files in RAM. I suggested you to store them in tree rather that list, you declined

  • support multipart archive files

How's the status of this?

Didn't event thought starting this

@romibi
Copy link
Owner Author

romibi commented Oct 17, 2023

Regarding tree structure:
Of course for outputting it the filenames and paths need to be converted to a tree structure before displaying it.
That can either be done locally in some function in cli app.
Or I've done that for the Gui already … mabye that logic can be extracted to some common place.

But the PackedMetaData and ScrapPackedFile classes should stay representing how the packed fileformat is structured.

I might do this myself at some point … but it's not important …

Regarding multipart archive files
Don't worry. If you want and have a good idea on how to do it you can do it … if not …
For me it's not a hight priority. Just was wondering if it hinders your cli scripting or not.

@Strongleong
Copy link
Collaborator

I have a question about multipart containers.

What if I want to check what is on one specific packed file. Let's say data01.packed
Should be this option opt-in and the app will open packed files in multipart mode by default?
Something like this

ScrapPackedExplorerCli data01.packed list                 # Will search for all dataXX.packed files and combine them
ScrapPackedExplorerCli data01.packed list --single   # Will open only data01.packed

Or opt-out?

ScrapPackedExplorerCli data01.packed list                       # Will open only data01.packed
ScrapPackedExplorerCli data01.packed list --multipart   # Will search for all dataXX.packed files and combine them

@Strongleong
Copy link
Collaborator

search content (maybe)

You can mark it as done scine we have -q flag in list command

@romibi
Copy link
Owner Author

romibi commented Oct 19, 2023

I have a question about multipart containers.

I'd say on the first part default behaviour is consodering all files except when disabled by argument.
On other parts only consider that one file.

Btw, do you know? Is there any marker in the files that they are multipart or is it just the names? (regarding the packed files in remaster)

@romibi
Copy link
Owner Author

romibi commented Oct 19, 2023

search content (maybe)

You can mark it as done scine we have -q flag in list command

Isn't that only for searching filenames? (currently not on PC to check)

@Strongleong
Copy link
Collaborator

Do you want to search by content too?

@romibi romibi pinned this issue Oct 19, 2023
@romibi
Copy link
Owner Author

romibi commented Oct 19, 2023

is already done and ticked off …

And there's a reasone there's a "(maybe)" in

  • search content (maybe)

😄

@Strongleong
Copy link
Collaborator

Oh. I thought that this is search by content (of the packed file)

@Strongleong
Copy link
Collaborator

Btw, do you know? Is there any marker in the files that they are multipart or is it just the names? (regarding the packed files in remaster)

To my knowledge - no. And to my lesser knowledge - this is how multipart archives (rar, zip, gz) works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants