Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove OIDC_CREATE_USER configuration and generate an uuid in a OIDC created user password #1402

Merged
merged 3 commits into from
Dec 27, 2024

Conversation

zurdi15
Copy link
Member

@zurdi15 zurdi15 commented Dec 27, 2024

No description provided.

Copy link

github-actions bot commented Dec 27, 2024

Test Results

92 tests  ±0   92 ✅ ±0   26s ⏱️ -3s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit f7a4699. ± Comparison against base commit d457ce0.

♻️ This comment has been updated with latest results.

@dataway
Copy link
Contributor

dataway commented Dec 27, 2024

Should not derive the username from the email claim. It would be better to use the preferred_username claim.

Neither the email not the preferred_username are unique however. See OIDC Core, section 5.7. (https://openid.net/specs/openid-connect-core-1_0.html#ClaimStability) Ideally the claims sub and iss should be stored in the database. This would also allow future support for multiple IdPs.

@gantoine
Copy link
Member

Ideally the claims sub and iss should be stored in the database.

This is something we (or another contributer) can tackle in a future release, ad I'm sure there is more functionality we'll need to add in the future around openid/sso.

@zurdi15 zurdi15 merged commit 324f5d7 into master Dec 27, 2024
9 checks passed
@zurdi15 zurdi15 deleted the fix/remove-oidc-create-user-env-variable branch December 27, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants