Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Login not working on Chrome for IOS #148

Open
lafama opened this issue Aug 24, 2018 · 7 comments
Open

Google Login not working on Chrome for IOS #148

lafama opened this issue Aug 24, 2018 · 7 comments

Comments

@lafama
Copy link

lafama commented Aug 24, 2018

Am unable to login/signup via Google on Iphone/IOS. The pop opens but after authentication reverts to the pop up login page

@ronzeidman
Copy link
Owner

Sorry, I don't have a mac or an ios device so I can't test it, would appreciate help debugging this issue though

@lafama
Copy link
Author

lafama commented Nov 1, 2018

Hi,
I finally managed to know whats happening. Pop-ups are not allowed on chrome ios, is there another way to authenticate other than using this


additionalUrlParams: {
 display: 'popup'}

@ronzeidman
Copy link
Owner

Currently no, I have a plan to create a redirect routes with no popups at all, but I don't have the time to implement it.

@lafama
Copy link
Author

lafama commented Nov 14, 2018

Hi,
I figured out what the problem is

 cordova = cordova === null ? this.isCordovaApp() : cordova;

This code on chrome for IOS always returns true (makes it a cordova app ). I think we should have it set to false by default instead if null

@ronzeidman
Copy link
Owner

Interesting, I'll look into it soon

ronzeidman added a commit that referenced this issue Nov 21, 2018
@ronzeidman
Copy link
Owner

I've changed the isCordovaApp logic a bit, maybe it works now, it's in the https://github.com/ronzeidman/ng2-ui-auth/tree/twitter_popup branch.
Test it and if everything works fine I'll publish a new version.

@ronzeidman
Copy link
Owner

try version 9.2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants