Fix Roo::Base#each_with_pagename degraded at #576 #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! appreciate it. |
|
Any ETA on merging this one?.. It's been pending for a while... |
|
Bump |
kakubin
force-pushed
the
fix_each_with_pagename
branch
from
ef23bce
to
06eff9c
Compare
|
@patrickkulling could you take a look at this please? |
patrickkulling
approved these changes
Sep 12, 2023
|
@patrickkulling thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Roo::Excel#each_with_pagenamebroken at this change.It intended to add feature to return Enumerator if block is not given, on the other side, it should keep previous behavior.
In fact, the latter was not followed.
This PR fix the behavior when block given.