fix(deps): downgrade anyhow version to 1.0.76 #2877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
new version of anyhow with std backtrace is much slower: dtolnay/anyhow#347 ``` cargo bench --bench bench_utils ... anyhow_error_bench/anyhow_v1.0.93 time: [15.040 ns 15.148 ns 15.259 ns] change: [+1.5448% +2.1215% +2.7219%] (p = 0.00 < 0.05) Performance has regressed. anyhow_error_bench/anyhow_v1.0.76 time: [6.2104 ns 6.2182 ns 6.2278 ns] change: [-0.4029% -0.1998% +0.0002%] (p = 0.06 > 0.05) No change in performance detected. Found 10 outliers among 100 measurements (10.00%) 2 (2.00%) high mild 8 (8.00%) high severe ```
Downgraded anyhow dependency from version 1.0.93 to 1.0.76. Won't break anything but gain better perf.
popcnt1
requested review from
jolestar,
wow-sven,
baichuan3 and
steelgeek091
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
jolestar
approved these changes
Nov 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
new version of anyhow with std backtrace is much slower: dtolnay/anyhow#347
Downgraded anyhow dependency from version 1.0.93 to 1.0.76. Won't break anything but gain better perf.