Merge pull request #1187 from kethinov/0.21.2

0.21.2
rooseveltframework · Aug 9, 2022 · b9443a8 · b9443a8
2 parents e24c752 + b2247c5
commit b9443a8
Show file tree

Hide file tree

Showing 6 changed files with 86 additions and 85 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,12 @@
 
 - Put your changes here...
 
+## 0.21.2
+
+- Fixed bug where the config auditor would complain about the `makeBuildArtifacts` param being set to string.
+- Static site generator will now run the HTML validator against rendered templates in dev mode only.
+- Various dependencies updated.
+
 ## 0.21.1
 
 - Static site generator can now be supplied models by file instead of by configuration. If model data is not supplied by configuration, Roosevelt will try to automatically load a model from a JS file with the same name alongside the template if it exists instead.

diff --git a/README.md b/README.md
@@ -767,48 +767,48 @@ Resolves to:
           ]
           ```
 
-          - Webpack bundle example declaring one bundle only used in `dev` mode:
-
-              ```json
-              [
-                {
-                  "env": "dev",
-                  "config": {
-                    "entry": "${js.sourcePath}/main.js",
-                    "output": {
-                      "path": "${publicFolder}/js",
-                      "filename": "bundle.js"
-                    }
+        - Webpack bundle example declaring one bundle only used in `dev` mode:
+
+            ```json
+            [
+              {
+                "env": "dev",
+                "config": {
+                  "entry": "${js.sourcePath}/main.js",
+                  "output": {
+                    "path": "${publicFolder}/js",
+                    "filename": "bundle.js"
                   }
                 }
-              ]
-              ```
-
-          - Webpack bundle example declaring multiple bundles:
-
-              ```json
-              [
-                {
-                  "config": {
-                    "entry": "${js.sourcePath}/main.js",
-                    "output": {
-                      "path": "${publicFolder}/js",
-                      "filename": "bundle.js"
-                    }
+              }
+            ]
+            ```
+
+        - Webpack bundle example declaring multiple bundles:
+
+            ```json
+            [
+              {
+                "config": {
+                  "entry": "${js.sourcePath}/main.js",
+                  "output": {
+                    "path": "${publicFolder}/js",
+                    "filename": "bundle.js"
                   }
-                },
-                {
-                  "config": {
-                    "entry": "${js.sourcePath}/moreStuff.js",
-                    "output": {
-                      "path": "${publicFolder}/js",
-                      "filename": "bundle2.js"
-                    }
+                }
+              },
+              {
+                "config": {
+                  "entry": "${js.sourcePath}/moreStuff.js",
+                  "output": {
+                    "path": "${publicFolder}/js",
+                    "filename": "bundle2.js"
                   }
-                },
-                etc...
-              ]
-              ```
+                }
+              },
+              etc...
+            ]
+            ```
 
   - Default: *[Object]*
 

diff --git a/lib/scripts/configAuditor.js b/lib/scripts/configAuditor.js
@@ -165,7 +165,7 @@ function configAudit (appDir) {
           checkTypes(userParam, key, ['null', 'string'])
           break
         case 'makeBuildArtifacts':
-          checkTypes(userParam, key, ['boolean'])
+          checkTypes(userParam, key, ['boolean', 'string'])
           break
         case 'https': {
           checkTypes(userParam, key, ['boolean', 'object'])

diff --git a/lib/sourceParams.js b/lib/sourceParams.js
@@ -438,11 +438,6 @@ module.exports = (params, app, appSchema) => {
   // configure logger with params
   const logger = new Logger(params.logging)
 
-  // if we're using Roosevelt as a static site generator, then we're always in dev mode
-  if (params.makeBuildArtifacts === 'staticsOnly') {
-    params.mode = 'development'
-  }
-
   // set mode specific overrides
   if (params.mode === 'production' || params.mode === 'production-proxy') {
     process.env.NODE_ENV = 'production'

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -8,7 +8,7 @@
       "url": "https://github.com/rooseveltframework/roosevelt/graphs/contributors"
     }
   ],
-  "version": "0.21.1",
+  "version": "0.21.2",
   "files": [
     "defaultErrorPages",
     "lib",