Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependency cheerio to v1.0.0 #682

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update dependency cheerio to v1.0.0 #682

wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Aug 9, 2024 •
edited
Loading

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
cheerio (source) 1.0.0-rc.12 -> 1.0.0 age adoption passing confidence

Release Notes

cheeriojs/cheerio (cheerio)

v1.0.0

Compare Source

Cheerio 1.0 is here! 🎉

Announcement Blog Post

Breaking Changes

New Features

Fixes

Other

Full Changelog: cheeriojs/cheerio@v1.0.0-rc.12...v1.0.0

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot changed the title Update dependency cheerio to v1.0.0 Update dependency cheerio to v1.0.0 - autoclosed Sep 16, 2024
@renovate renovate bot closed this Sep 16, 2024
@renovate renovate bot deleted the renovate/cheerio-1.x branch September 16, 2024 11:52
@renovate renovate bot changed the title Update dependency cheerio to v1.0.0 - autoclosed Update dependency cheerio to v1.0.0 Sep 21, 2024
@renovate renovate bot restored the renovate/cheerio-1.x branch September 21, 2024 13:55
@renovate renovate bot reopened this Sep 21, 2024
@kethinov kethinov added the breaking Change will require a major version bump label Sep 21, 2024
@kethinov
Copy link
Member

This causes webpack errors when teddy is used in frontend:

❌  Webpack bundling error: Module not found: Error: Can't resolve 'stream' in 'node_modules/teddy/dist'

BREAKING CHANGE: webpack < 5 used to include polyfills for node.js core modules by default.
This is no longer the case. Verify if you need this module and configure a polyfill for it.

If you want to include a polyfill, you need to:
	- add a fallback 'resolve.fallback: { "stream": require.resolve("stream-browserify") }'
	- install 'stream-browserify'
If you don't want to include a polyfill, you can use an empty module like this:
	resolve.fallback: { "stream": false }

Attempts to modify teddy's webpack config in the ways described there don't seem to solve the problem.

@kethinov kethinov added the upstream issue Third-party dependency issue label Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking Change will require a major version bump upstream issue Third-party dependency issue
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kethinov