Skip to content

Commit

Permalink
[ntuple] Remove outdated comment
Browse files Browse the repository at this point in the history
We require buffered writing with the RNTupleParallelWriter because
of its better scalability and less fragmented output files, see
also #14939.
  • Loading branch information
hahnjo committed Jan 8, 2025
1 parent 9b2195d commit 11e88b7
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions tree/ntuple/v7/src/RNTupleParallelWriter.cxx
Original file line number Diff line number Diff line change
Expand Up @@ -182,9 +182,6 @@ std::shared_ptr<ROOT::Experimental::RNTupleFillContext> ROOT::Experimental::RNTu
std::lock_guard g(fMutex);

auto model = fModel->Clone();

// TODO: Think about honoring RNTupleWriteOptions::SetUseBufferedWrite(false); this requires synchronization on every
// call to CommitPage() *and* preparing multiple cluster descriptors in parallel!
auto sink = std::make_unique<Internal::RPageSinkBuf>(std::make_unique<RPageSynchronizingSink>(*fSink, fSinkMutex));

// Cannot use std::make_shared because the constructor of RNTupleFillContext is private. Also it would mean that the
Expand Down

0 comments on commit 11e88b7

Please sign in to comment.