[ntuple] Forbid RNTupleParallelWriter with a non-binary TFile

root-project · Jan 8, 2025 · 536f972 · 536f972
1 parent 11e88b7
commit 536f972
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 0 deletions.
diff --git a/tree/ntuple/v7/src/RNTupleParallelWriter.cxx b/tree/ntuple/v7/src/RNTupleParallelWriter.cxx
@@ -21,7 +21,9 @@
 #include <ROOT/RPageStorage.hxx>
 #include <ROOT/RPageStorageFile.hxx>
 
+#include <TDirectory.h>
 #include <TError.h>
+#include <TFile.h>
 
 namespace {
 
@@ -168,6 +170,16 @@ std::unique_ptr<ROOT::Experimental::RNTupleParallelWriter>
 ROOT::Experimental::RNTupleParallelWriter::Append(std::unique_ptr<RNTupleModel> model, std::string_view ntupleName,
                                                   TDirectory &fileOrDirectory, const RNTupleWriteOptions &options)
 {
+   auto file = fileOrDirectory.GetFile();
+   if (!file) {
+      throw RException(
+         R__FAIL("RNTupleParallelWriter only supports writing to a ROOT file. Cannot write into a directory "
+                 "that is not backed by a file"));
+   }
+   if (!file->IsBinary()) {
+      throw RException(R__FAIL("RNTupleParallelWriter only supports writing to a ROOT file. Cannot write into " +
+                               std::string(file->GetName())));
+   }
    if (!options.GetUseBufferedWrite()) {
       throw RException(R__FAIL("parallel writing requires buffering"));
    }

diff --git a/tree/ntuple/v7/test/ntuple_parallel_writer.cxx b/tree/ntuple/v7/test/ntuple_parallel_writer.cxx
@@ -293,6 +293,16 @@ TEST(RNTupleParallelWriter, ForbidModelWithSubfields)
    }
 }
 
+TEST(RNTupleParallelWriter, ForbidNonRootTFiles)
+{
+   FileRaii fileGuard("test_ntuple_parallel_forbid_xml.xml");
+
+   auto model = RNTupleModel::Create();
+   auto file = std::unique_ptr<TFile>(TFile::Open(fileGuard.GetPath().c_str(), "RECREATE"));
+   // Opening an XML TFile should fail
+   EXPECT_THROW(RNTupleParallelWriter::Append(std::move(model), "ntpl", *file), ROOT::RException);
+}
+
 TEST(RNTupleFillContext, FlushColumns)
 {
    FileRaii fileGuard("test_ntuple_context_flush.root");