Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RF] Weighted data in HistFactory #10744

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

cburgard
Copy link
Contributor

This Pull request:

HistFactory doesn't currently allow to produce workspaces with weighted data.
This PR sets out to try and alleviate this shortcoming.

Changes or fixes:

Add a configuration-option storeDataError.

Checklist:

  • tested changes locally
  • updated the docs (if necessary)

This PR fixes #

@guitargeek guitargeek self-assigned this Jun 13, 2022
@guitargeek guitargeek changed the title Weighted data in HistFactory [RF] Weighted data in HistFactory Dec 16, 2022
@root-project root-project deleted a comment from phsft-bot Jan 10, 2025
@root-project root-project deleted a comment from phsft-bot Jan 10, 2025
@root-project root-project deleted a comment from phsft-bot Jan 10, 2025
Copy link

github-actions bot commented Jan 10, 2025

Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit c600e01.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@guitargeek guitargeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I fixed up the implementation.

@guitargeek guitargeek merged commit cec12ef into root-project:master Jan 22, 2025
18 of 20 checks passed
@guitargeek guitargeek deleted the weighted-data branch January 22, 2025 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants