Improve TRatioPlot painting #14891
Merged
Improve TRatioPlot painting #14891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is not good idea to add or remove objects from pad list of primitives when TRatioPlot::Paint is called Therefore create TLine objects once and just update position If lines are not visible - make them as point in the frame corner
Same as grid lines - one should not recreate TGaxis objects but just change their attributes when painting is performed
If ratio plot load from the file, connections to the signals are not automatically restored. Therefore check if connections are there - and re-establish them if they are missing
No need to call several update methods once
Also no need to use TClass methods via IsA().
Make ratio plot as first object in list of primitives. When painting - one can modify axes attributes before they really painted
No need to class change version - it was changed before IsDrawn() method is useless - handling of signals can be possible only when they are connected - after drawing Format a bit header file
There are no more dummy/invisible primitives caused by TRatioPlot painting before therefore PS/PDF are smaller
Also check allowed range in SetSplitFraction
|
Starting build on |
couet
approved these changes
Mar 6, 2024
Test Results 10 files 10 suites 2d 1h 41m 11s ⏱️ For more details on these failures, see this check. Results for commit 0f08309. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before several objects like
TLineandTGaxiscould be recreated and drawn duringTRatioPlot::Paint()which was wrong approach.Now in paint only attributes are updated - all necessary objects created when
TRatioPlot::Draw()is called.Put
TRatioPlotas first primitive in the pad. By thisTGaxisandTLineattributes updated before they will be actually painted.Improve signals handling. Only one
TRatioPlot::fIsUpdateis used now to prevent multiple actions at once. Make it transient.Adjust
stressGraphicsrefs files - PDF and PS are smaller now while less dummy primitives are created