Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RF] Update xroofit #14900

Merged
merged 1 commit into from
Mar 13, 2024
Merged

[RF] Update xroofit #14900

merged 1 commit into from
Mar 13, 2024

Conversation

will-cern
Copy link
Contributor

This PR addresses:

  • Bug fix to plotting datasets horizontal error bars
  • Bug fix to obtaining datasets of reduced pdfs (i.e. get the corresponding reduced dataset)
  • Beginning to add some documentation for xRooNode
  • Adds a cling interpreter method for xRooNode to print the names of the child nodes

@phsft-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@guitargeek
Copy link
Contributor

@phsft-bot build

@phsft-bot
Copy link
Collaborator

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default
How to customize builds

@guitargeek guitargeek self-assigned this Mar 6, 2024
@guitargeek guitargeek changed the title update xroofit [RF] Update xroofit Mar 6, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2024

Test Results

    11 files      11 suites   1d 20h 33m 56s ⏱️
 2 582 tests  2 582 ✅ 0 💤 0 ❌
26 548 runs  26 548 ✅ 0 💤 0 ❌

Results for commit ad402d6.

guitargeek
guitargeek approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@guitargeek guitargeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates! I'll take care of the backport.

@guitargeek guitargeek merged commit 0823995 into root-project:master Mar 13, 2024
15 of 17 checks passed
This was referenced Mar 13, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guitargeek guitargeek guitargeek approved these changes

@lmoneta lmoneta Awaiting requested review from lmoneta lmoneta is a code owner

Assignees

@guitargeek guitargeek

Labels
in:RooFit/RooStats
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@will-cern @phsft-bot @guitargeek