Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ntuple] Improve error handling of RNTupleParallelWriter #17368

Merged
merged 3 commits into from
Jan 8, 2025

Conversation

hahnjo
Copy link
Member

@hahnjo hahnjo commented Jan 7, 2025

No description provided.

hahnjo added 3 commits January 7, 2025 17:02
We require buffered writing with the RNTupleParallelWriter because
of its better scalability and less fragmented output files, see
also root-project#14939.
@hahnjo hahnjo requested review from jblomer and silverweed January 7, 2025 16:07
@hahnjo hahnjo self-assigned this Jan 7, 2025
Copy link

github-actions bot commented Jan 7, 2025

Test Results

    17 files      17 suites   3d 17h 43m 2s ⏱️
 2 680 tests  2 680 ✅ 0 💤 0 ❌
43 906 runs  43 906 ✅ 0 💤 0 ❌

Results for commit 0d55b49.

Copy link
Contributor

@silverweed silverweed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hahnjo hahnjo merged commit 536f972 into root-project:master Jan 8, 2025
20 checks passed
@hahnjo hahnjo deleted the ntuple-parallel-writer branch January 8, 2025 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants