Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[df] Fix Vary sanity check for typedefs #17478

Merged
merged 1 commit into from
Jan 23, 2025
Merged

[df] Fix Vary sanity check for typedefs #17478

merged 1 commit into from
Jan 23, 2025

Conversation

vepadulano
Copy link
Member

@vepadulano vepadulano commented Jan 21, 2025 •
edited
Loading

Fixes #17486

@vepadulano vepadulano self-assigned this Jan 21, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 22, 2025 •
edited
Loading

Test Results

    18 files      18 suites   4d 14h 24m 50s ⏱️
 2 687 tests  2 663 ✅ 23 💤 1 ❌
46 638 runs  46 636 ✅  0 💤 2 ❌

For more details on these failures, see this check.

Results for commit 72aebe2.

♻️ This comment has been updated with latest results.

@vepadulano vepadulano linked an issue Jan 22, 2025 that may be closed by this pull request
Sanity check for Vary is too restrictive #17486
Closed
1 task
@vepadulano vepadulano force-pushed the rdf-vary-fix-sanity-check branch 2 times, most recently from 783252b to bfad11b Compare January 22, 2025 13:48
@vepadulano vepadulano marked this pull request as ready for review January 22, 2025 13:49
@vepadulano vepadulano requested a review from pcanal January 22, 2025 14:31
@vepadulano vepadulano force-pushed the rdf-vary-fix-sanity-check branch from bfad11b to 72aebe2 Compare January 22, 2025 15:18
martamaja10
martamaja10 approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@martamaja10 martamaja10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix Vincenzo!

@vepadulano vepadulano merged commit c9c762b into root-project:master Jan 23, 2025
18 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martamaja10 martamaja10 martamaja10 approved these changes

@pcanal pcanal pcanal approved these changes

Assignees

@vepadulano vepadulano

Labels
in:RDataFrame
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sanity check for Vary is too restrictive
3 participants
@vepadulano @pcanal @martamaja10