Update reference public members of TH1 #1040
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
2 tasks
pcanal
requested review from
vepadulano and
lmoneta
and removed request for
pcanal
|
@phsft-bot build |
|
Starting build on |
|
Build failed on ROOT-ubuntu2004/python3. |
|
Build failed on windows10/default. Failing tests: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the reference log for the MemberComments test so that it reflects the changes proposed in root-project/root#14077.
These changes include making public the enum
TH1::EInconsistencyBits, and the addition of new public data members changes the output of runMemberComments.C, making the test fail.