Re-enable fastcloningeventtree tests #1059
Conversation
|
Starting build on |
|
Build failed on ROOT-ubuntu2004/python3. Failing tests: |
|
Build failed on windows10/default. Failing tests: |
|
I think we are almost there with this fix. It is just necessary to disable this test on Windows. |
|
@bellenot Is there an easy way to fix this test on Windows (seem a question of access a local |
I already took a look and explained to Vincenzo. The Event.lib (and dll) are generated using a gnu makefile, hence not compatible with Windows. One should port that to CMake... |
…roject#716)"" This reverts commit 53c22ac.
|
Starting build on |
|
It turns out these files were already ported to cmake previously, then the change was reverted #716 I re-reverted the change, make the needed adjustments afterwards using fixtures. On my machine everything works again now, let's see the Windows CI |
|
Starting build on |
|
Build failed on mac12arm/cxx20. Warnings:
Failing tests:
|
|
Starting build on |
|
Build failed on ROOT-ubuntu2204/nortcxxmod. Failing tests: |
|
Build failed on ROOT-ubuntu2004/python3. Failing tests:
|
|
Build failed on ROOT-performance-centos8-multicore/soversion. Failing tests: |
|
Build failed on mac12arm/cxx20. Warnings:
|
* The `fastcloningeventtree` folder is updated to using cmake instead of make. * The `ctrans.C` macro now properly loads the shared library built at the same directory of the input file * Relationship between `fastcloningeventtree` and `event` is made cleared. The first depends on the latter. They are thus placed in the same roottest subfolder
|
Starting build on |
|
Build failed on ROOT-ubuntu2204/nortcxxmod. Failing tests:
|
|
Build failed on ROOT-ubuntu2004/python3. Failing tests:
|
|
Build failed on ROOT-performance-centos8-multicore/soversion. Failing tests: |
|
@pcanal this is now ready for review |
|
@phsft-bot build |
|
Starting build on |
|
Build failed on ROOT-ubuntu2204/nortcxxmod. Failing tests: |
|
Build failed on ROOT-performance-centos8-multicore/soversion. Failing tests: |
|
Build failed on ROOT-ubuntu2004/python3. Failing tests: |
|
@phsft-bot build with flags -DCTEST_TEST_EXCLUDE_NONE=On |
|
Starting build on |
| ROOTTEST_ADD_TEST("${file_name}-${mode}" | ||
| COMMAND ${ROOT_root_CMD} -q -b -l "${CMAKE_CURRENT_SOURCE_DIR}/dt_wrap.C\(\"${file_name}.root\",${mode}\)" | ||
| DEPENDS EventGeneration | ||
| RUN_SERIAL |
There was a problem hiding this comment.
There should be a comment mentioning why this is here.
| EVENT_GENERATE_FILE(split-nine ${size} ${comp} 9 ${action} ${tracks}) | ||
| EVENT_GENERATE_TESTS(split-nine) | ||
|
|
||
| EVENT_GENERATE_FILE(stream-old ${size} ${comp} -1 ${action} ${tracks}) |
There was a problem hiding this comment.
| EVENT_GENERATE_FILE(stream-old ${size} ${comp} -1 ${action} ${tracks}) | |
| EVENT_GENERATE_FILE(stream-old 20 ${comp} -1 ${action} 30) |
was the old behavior ...
| # | ||
| function(EVENT_GENERATE_TESTS file_name) | ||
| foreach(mode 0;1;2;3;4) | ||
| ROOTTEST_ADD_TEST("${file_name}-${mode}" |
There was a problem hiding this comment.
The essential part of the testing was comparing to the references files (See OUTREF is the old cmake files), are we still doing that and/or what did we replace it with. (dt_RunDrawTest.sh was to cleanup the output so that despite intentional differences one could compare to a single reference file; see the grep -v in there).
This comparison was used to check for unexpected warning or error messages.
| @@ -0,0 +1,20 @@ | |||
| void ctrans(const char *filename) | |||
There was a problem hiding this comment.
We may want to use git mv to keep track of the history. (My github display claims it wasn't used).
There was a problem hiding this comment.
Can you confirm to git mv was used?
| $(MERGEFILES): %: $(ONEFILES) $(TWOFILES) | merged | ||
| $(CMDECHO) $(CALLROOTEXE) -q -b -l 'mtrans.C("$(@F)")' > $@.create.log 2>&1 |
There was a problem hiding this comment.
Which targets are covering this set of tests?
| CloneTree.root: make_CloneTree.C | ||
| $(CMDECHO) $(CALLROOTEXE) -q -b -l make_CloneTree.C > make_CloneTree.log 2>&1 |
| SplitMismatch.clog: runSplitMismatch_C.$(DllSuf) | ||
| $(CMDECHO) $(CALLROOTEXE) -q -b -l runSplitMismatch.C+ 2>&1 | sed -e 's:file .*roottest:file .../roottest:' > SplitMismatch.clog | ||
|
|
There was a problem hiding this comment.
Can you also check into this one?
| Tuple_merge.root: Tuple_1.root Tuple_2.root $(ROOTCORELIBS) | ||
| $(CMDECHO) hadd -f Tuple_merge.root Tuple_1.root Tuple_2.root > Tuple_merge.log | ||
|
|
||
| outoforder.log: Tuple_merge.root | ||
|
|
||
| outoforder: outoforder.log | ||
| $(TestDiff) | ||
|
|
||
| filemergererror: filemergererror.log | ||
| $(TestDiff) | ||
|
|
||
| badmix: badmix.log | ||
| $(TestDiff) | ||
|
|
||
|
|
||
| abstract.root: abstract_C.$(DllSuf) | ||
| $(CMDECHO) root.exe -b -l -q 'abstract.C+(0)' > abstract_root.log 2>&1 | ||
|
|
||
| copy-abstract.root: abstract_C.$(DllSuf) abstract.root | ||
| $(CMDECHO) root.exe -b -l -q 'abstract.C+(1)' > abstract_root.log 2>&1 | ||
|
|
||
| abstract.log: copy-abstract.root | ||
|
|
||
| abstract: abstract.log |
There was a problem hiding this comment.
Can you also check into these tests? (outoforder, filemergererror, badmix, abstract, copy-abstract)
|
Build failed on ROOT-ubuntu2004/python3. Failing tests: |
|
Build failed on ROOT-performance-centos8-multicore/soversion. Failing tests: |
|
I propose to merge this PR to close root-project/root#14579 and work on the other tests at a later stage: does it make sense? |
|
There are several outstanding issue/conversation holding back the merge. |
Fixes root-project/root#14579