Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full- chain testing with headless chrome browser #1157

Conversation

DuesselbergAdrian
Copy link
Contributor

@DuesselbergAdrian DuesselbergAdrian commented Aug 2, 2024

DO NOT MERGE!!! This PR adds testing of new SVGs on Mac. It includes:

  • Reference files for new SVGs
  • A new function test_new_svg() to create svgs from reference json files and then compare them.
  • A manual script how create new reference files

@DuesselbergAdrian DuesselbergAdrian self-assigned this Aug 2, 2024
@linev
Copy link
Member

linev commented Aug 28, 2024

@DuesselbergAdrian

I am very close to make testing of JSROOT ready with headless browsers.
It looks promising - for the moment I just cleanup JSROOT code that produced SVG/PNG/JSON files match on browser and with node.js.

Here my working macro:

https://github.com/linev/jsroot-test/blob/puppeteer/puppeteer.js

Probably then one can do very similar with ROOT http server.

@DuesselbergAdrian
Copy link
Contributor Author

Ok I opened a new PR: #1179
Since I don't have much time left, I will run the test on all platforms and exclude all tests which are failing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants