[hadd] add tests for hadd argument parsing #1201
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silverweed
force-pushed
the
hadd_argparse
branch
2 times, most recently
from
55b693d to
3137bb0
Compare
silverweed
force-pushed
the
hadd_argparse
branch
2 times, most recently
from
65a7982 to
3f68173
Compare
2 tasks
pcanal
reviewed
Nov 12, 2024
| COMMAND ${ROOT_root_CMD} -q -b -l "hadd_gen_input_tree.C(\"hadd_args_in.root\")" | ||
| ) | ||
|
|
||
| ROOTTEST_ADD_TEST(test_hadd_args_n0 |
There was a problem hiding this comment.
Does this test only verifies that the message printed by hadd are correct? If yes, should we add some (minimal) test that the file produces is as expected (minimal requirement: contains the object we expects).
Rather than a POSTCMD deleting the file, I recommend a PRECMD (or not when we want to test that hadd complains about existing files). We may also want to keep the file after the end to have an opportunity to hand check the file.
silverweed
force-pushed
the
hadd_argparse
branch
from
3f68173 to
b01f234
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New test suite for hadd to go together with root-project/root#16090