Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[request] compatibility with eslint 9.x #2619

Open
3 tasks done
pyksid opened this issue Jun 29, 2024 · 1 comment
Open
3 tasks done

[request] compatibility with eslint 9.x #2619

pyksid opened this issue Jun 29, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request in-progress Active work planned Planned work

Comments

@pyksid
Copy link

pyksid commented Jun 29, 2024

Agreement

Describe the issue

After upgrading from ESLint 8.x to 9.x, when running bud build, an error occurred and prevented to build assets.

Expected Behavior

bud.js builds assets.

Actual Behavior

$ yarn build

╭ bud [9039cc93a0cfeb1e]                                                                                                                                     ./public
│
│ │ [eslint] Invalid Options:
│ │ - Unknown options: extensions, resolvePluginsRelativeTo, useEslintrc
│ │ - 'extensions' has been removed.
│ │ - 'resolvePluginsRelativeTo' has been removed.
│
╰ 1 error

Steps To Reproduce

yarn build

version

6.23.1

Logs

No response

Configuration

No response

Relevant .budfiles

No response

@pyksid pyksid added the bug Something isn't working label Jun 29, 2024
@kellymears kellymears removed the bug Something isn't working label Jun 30, 2024
@kellymears kellymears changed the title [bug] bud.js not working with Stylelint 9.x [bug] compatibility with eslint 9.x Jun 30, 2024
@kellymears
Copy link
Member

kellymears commented Jun 30, 2024

I'm removing the bug label because we can only support what we've committed to support, and Eslint 9 is a major upgrade we have not undertaken yet. You can check out the upgrade guide if you're interested.

We won't be able to upgrade @roots/* configs until our next major version because it's such a huge change. It also requires node@18, while we're still trying to support node@16 until bud@7.

eslint-webpack-plugin added support for eslint@9.x.x in v4.2.0 but I notice that if you follow the eslint docs and export an Array from eslint.config.js it will fail (I'm guessing eslint-webpack-plugin tries to parse it as a plain object rather than an array of plain objects, although I didn't look at the source).

Nevertheless, updating it seems like a good idea #2620. I'm just saying that I think it's likely eslint-webpack-plugin will see further changes in support of eslint v9 in the future. We're beholden to any of those changes.

In that same PR there is also a new examples/eslint-9.0.0 project which works using v9.

@kellymears kellymears changed the title [bug] compatibility with eslint 9.x [request] compatibility with eslint 9.x Jun 30, 2024
@kellymears kellymears self-assigned this Jun 30, 2024
@kellymears kellymears added enhancement New feature or request in-progress Active work planned Planned work labels Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request in-progress Active work planned Planned work
Projects
None yet
Development

No branches or pull requests

2 participants