Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overriding "pm" in PHP-FPM's pool config #1542

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

gutobenn
Copy link
Contributor

@gutobenn gutobenn commented Aug 16, 2024

This PR adds support for overriding the value of 'pm' in PHP-FPM's pool config.

This can be done by setting a value to the variable php_fpm_pm, just like you can already do to other configs.

Example:

# group_vars/all/php.yml
php_fpm_pm: 'static'

@swalkinshaw
Copy link
Member

allowing different settings for each environment.

The goal is for each environment (eg: production, staging, etc) and not per site? If so, this might be confusing since usually parameters under a site are meant to be site specific, but the config created is not site specific.

@gutobenn gutobenn changed the title Allow setting different PHP-FPM params in environment config Allow setting different PHP-FPM pool params for each site Aug 19, 2024
@gutobenn gutobenn changed the title Allow setting different PHP-FPM pool params for each site Allow overriding "pm" in PHP-FPM's pool config Aug 19, 2024
@gutobenn
Copy link
Contributor Author

gutobenn commented Aug 19, 2024

@swalkinshaw Thanks for the feedback! I've reformulated my solution.

It seems that the other parameters (e.g., php_fpm_pm_max_children, php_fpm_pm_start_servers, and so on) might already be overridden. Therefore, I adjusted the php-fpm-pool-wordpress.conf.j2 code to also support overriding the pm.

@swalkinshaw swalkinshaw merged commit dcb581b into roots:master Aug 19, 2024
2 checks passed
@swalkinshaw
Copy link
Member

Thanks @gutobenn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants